Re: [PATCH 07/10] sulogin: reduce vulnerability surface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 23, 2017 at 09:58:18PM +0100, Sami Kerola wrote:
> --- a/login-utils/sulogin.c
> +++ b/login-utils/sulogin.c
...
>  static void tcinit(struct console *con)
>  {
> -	int mode = 0, flags = 0;
> +	int flags = 0;
>  	struct termios *tio = &con->tio;
> -	int fd = con->fd;
> +	const int mode = 0, fd = con->fd;

Is it correct to use const for "mode" if we use it 

    ioctl(fd, KDGKBMODE, &mode)

... I think gcc does not complain because ioclt() is promiscuous
bastard :-)

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux