[PATCH 1/5] tests: remove fincore SMALLER_THAN_PAGESIZE tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Ruediger Meier <ruediger.meier@xxxxxxxxxxx>

These tests failed for example on ext4 with a non-default
blocksize 1024. In this case it seems that the kernel only
caches a full page if we read at least PAGE_SIZE -BLOCK_SIZE +1.

Both tests also failed on NFS allthough block size seems to be
1M there.

We still keep the test for PAGE_SIZE-1 which seems to work more
reliable.

Signed-off-by: Ruediger Meier <ruediger.meier@xxxxxxxxxxx>
---
 tests/expected/fincore/count | 6 ------
 tests/ts/fincore/count       | 8 --------
 2 files changed, 14 deletions(-)

diff --git a/tests/expected/fincore/count b/tests/expected/fincore/count
index d5ce062..4665136 100644
--- a/tests/expected/fincore/count
+++ b/tests/expected/fincore/count
@@ -3,16 +3,12 @@ fincore: failed to open: no_such_file: No such file or directory
 return value: 1
     0    0 i_EMPTY_FILE
 return value: 0
-    1  2048 i_SMALLER_THAN_PAGESIZE__incore_
-return value: 0
     1  4095 i_PAGESIZE_-1__incore_
 return value: 0
     1  4096 i_JUST_PAGESIZE_incore_
 return value: 0
     0  4096 i_JUST_PAGESIZE_directio_
 return value: 0
-    2  4097 i_PAGESIZE_+_1__incore_
-return value: 0
     2  8192 i_TWO_PAGES_incore_
 return value: 0
     0  8192 i_TWO_PAGES_directio_
@@ -41,11 +37,9 @@ return value: 0
 fincore: failed to open: no_such_file: No such file or directory
 PAGES      SIZE FILE
     0         0 i_EMPTY_FILE
-    1      2048 i_SMALLER_THAN_PAGESIZE__incore_
     1      4095 i_PAGESIZE_-1__incore_
     1      4096 i_JUST_PAGESIZE_incore_
     0      4096 i_JUST_PAGESIZE_directio_
-    2      4097 i_PAGESIZE_+_1__incore_
     2      8192 i_TWO_PAGES_incore_
     0      8192 i_TWO_PAGES_directio_
     1      8192 i_TWO_PAGES_mixed_directio_incore_
diff --git a/tests/ts/fincore/count b/tests/ts/fincore/count
index 87e25a8..8f23fec 100755
--- a/tests/ts/fincore/count
+++ b/tests/ts/fincore/count
@@ -92,10 +92,6 @@ input=
 } >> $TS_OUTPUT 2>&1
 
 {
-    run_dd_test "SMALLER THAN PAGESIZE (incore)" $(( PAGE_SIZE / 2 ))
-} >> $TS_OUTPUT 2>&1
-
-{
     run_dd_test "PAGESIZE -1 (incore)" $(( PAGE_SIZE - 1 ))
 } >> $TS_OUTPUT 2>&1
 
@@ -108,10 +104,6 @@ input=
 } >> $TS_OUTPUT 2>&1
 
 {
-    run_dd_test "PAGESIZE + 1 (incore)" $(( PAGE_SIZE + 1 ))
-} >> $TS_OUTPUT 2>&1
-
-{
     run_dd_test "TWO PAGES(incore)" $(( 2 * PAGE_SIZE ))
 } >> $TS_OUTPUT 2>&1
 
-- 
1.8.5.6

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux