On 03/05/2017 03:52 PM, Sami Kerola wrote:
> + warnx(_("Invalid output format %s. "
> + "Choose from value:"), optarg);
> + fputc('\t', stderr);
> + for (j = 0; j < ARRAY_SIZE(output_names); j++)
> + fprintf(stderr, "%s%s", j == 0 ? "" : " ", output_names[j]);
> + fputc('\n', stderr);
> + exit(BLKID_EXIT_OTHER);
I see, it is saying "Choose a value from:". 'Choose from:" is enough,
it's confusing to use 'value' when it is also one of the choices.
I also see, that 2 of the output choices are deprecated. If they are
going to be excluded from the 'help' output, shouldn't they be excluded
from the error messages as well?
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
