Merged, but except: On Mon, Feb 13, 2017 at 10:06:34PM +0000, Sami Kerola wrote: > misc: unify function declarations [smatch scan] I agree that some unification would be nice, but don't like static __attribute__((__noreturn__)) __attribute__((__format__(printf, 1, 2))) void log_err(const char *fmt, ...); it would be better to keep all the attributes after declaration: static void log_err(const char *fmt, ...) __attribute__((__noreturn__)) __attribute__((__format__(printf, 1, 2))); it means new line for each attribute. IMHO it's more readable and you don't have to search for the function name, etc. Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html