On Fri, Feb 10, 2017 at 12:06:58PM +0900, Damien Le Moal wrote:
> Karel, Shaun,
>
> Tested on SAS and SATA host-managed drive. No problems detected.
> A few remarks though:
>
> 1) The term "lba" is being used throughout (command description and
> error messages). This is confusing when using 4K drives. Since in fact
> the unit used for the arguments and displayed results is the traditional
> 512B "sector", I think that "LBA" should be replaced by "sector" is all
> messages, command argument descriptions and man pages.
Fixed.
> 2) In kernel, the offset passed to the zone reset ioctl is indeed
> checked for alignment to the drive LBA size. So checking the offset
> passed to blkreset makes sense. However, the same check for report is a
> little too harsh since the kernel will accept an unaligned sector number
> (it will be aligned down to the containing zone start sector before
> issuing a report zones command to the drive). So we could get rid of
> that check I think.
Fixed.
> Otherwise, please feel free to add:
> Tested-by: Damien Le Moal <damien.lemoal@xxxxxxx>
Thanks.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
