On Thu, Feb 02, 2017 at 10:04:13AM -0500, J William Piggott wrote:
> Outside of our ongoing discussion below regarding a 'technically
> unnecessary' cast, I think Sami's work is ready for you to consider it
> for committing. I would be interested in your thoughts on the cast.
I have no strong opinion about it, for the reader it could be really
nice to follow code author ideas, but personally I think it's better
to not use it too often :-)
BTW, often bug in libblkid/fdisk is math without casts, something
like:
uint64_t x;
uint32_t a, b;
x = a + b
here it's better to be explicit and use (uint64) a + b. The same
problem if you write macros to hide some operations (we had this
problem in include/bitops.h).
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
