I got a report that TRIM is called many times on btrfs with subvolumes. I did a research and found that sys-utils/fstrim.c: uniq_fs_source_cmp() contains a code that compares not only file system sources (i. e. devices), but also roots. I doubt that it is needed in any situation. We just care about source, i. e. device node. I think that if it matches, it is always particular device duplicate. Root does not equal for btrfs subvolumes, but also it does not equal for bind mounts. And btrfs subvolumes remain duplicated after the whole de-duplication process. The patch assumes that the root comparison is not needed here at all. If it is not true, I will prepare another patch ignoring root specifically for btrfs. -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@xxxxxxxx Křižíkova 148/34 (Corso IIa) tel: +49 911 7405384547 186 00 Praha 8-Karlín fax: +420 284 084 001 Czech Republic http://www.suse.cz/ PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76 -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
