On 12 Dec 2016 15:01, Ruediger Meier wrote: > On Saturday 10 December 2016, Mike Frysinger wrote: > > On 20 Oct 2016 17:19, Karel Zak wrote: > > > On Thu, Oct 20, 2016 at 01:34:24PM +0200, Ruediger Meier wrote: > > > > For me it looks like the even the ncurses authors do not like > > > > their own pc files. Disabled by default and it's a pain to get > > > > them built with correct names and installed in the right > > > > location. Even --prefix does not work for their pc files. Plus > > > > the backward compatibility problem ... > > > > > > OK, I have applied: > > > > > > https://github.com/karelzak/util-linux/commit/e5cc93b5a8854fce80537 > > >f86a244977df212dcb5 > > > > > > with ncurses-config and fallback to old good AC_CHECK_LIB. > > > > > > We can add fallback to pkg-config too, but it sounds like overkill > > > if ncurses-config is everywhere. > > > > ugh, this change makes things worse. the point of using pkg-config > > is also to get sane cross-compiling. by always running `xxx-config`, > > it now breaks cross-compiling. > > Works for me, when adding the ncurses5-config to the PATH > $ /usr/i686-w64-mingw32/sys-root/mingw/bin/ncurses5-config --libs > -L/usr/i686-w64-mingw32/sys-root/mingw/lib -lncurses -ltinfo don't take this the wrong way (seriously, it's not personal or anything), but this statement implies you don't cross-compile regularly (or at all). this hack doesn't scale at all and is a horrible horrible idea. the fact that you managed to execute an arbitrary shell script is irrelevant here. > > why can't we just tell distros to fix their ncurses install ? it's > > not like 2.29, released a month ago, is getting rolled out to old > > distros where people can't update their ncurses systems. > > I guess we should better fix ncurses upstream, to avoid having ncurses > packages on any distros broken in different ways. working with upstream ncurses to get better/smoother defaults is always a good idea. but that doesn't lead into the next point. > > "it's hard" is a pretty weak argument for distro maintainers. > > No, no. This was about installing plain ncurses as a normal user > (./configure --prefix ...). If upstream does not provide .pc files by > default then we should not rely on them. You can't blame users nor > package maintainers for installing a lib in a way like upstream > recommends. sure i can. distro maintainers have like one job: maintain a distro. the fact that they have to read the docs and configure options to get a build with pc files isn't exactly onerous. as for users building their own distro, that's pretty uncommon. there are a lot of ways you could play that angle in (wrongly) trying to make the build system cater to their mistakes. why should every random pkg out there duplicate this kind of logic ? that said, i'm not advocating for *requiring* pc files. if util-linux wants to support a *fallback* of executing the old config scripts, that is fine. but it shouldn't be to the detriment of properly configured systems that have sane pc files available. -mike
Attachment:
signature.asc
Description: Digital signature
