Re: [PATCH 2/4] lsmem: new tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 04, 2016 at 01:10:06PM +0100, Heiko Carstens wrote:
> - you changed the alignment of nearly all columns from left to right,
> except for STATE and RANGE. For RANGE it does make sense to keep it aligned
> to the left, however for STATE it looks a bit inconsistent. Not sure if you
> missed to make it also align to the right?

Fixed, STATE is aligned to the right too.

> - the updated man page now says that the default output is subject to
> change; but it should not change in order to be compatible with the old
> lsmem tool within s390-tools.

Well, I'd like to force users to use --output in scripts for our
ls-like tools, but you're right. We should be friendly to the current
s390-tools users.  I have a little bit changed the sentence, and now
it recommends --output and there is also note about compatibility with
s390-tools.

>  sys-utils/lsmem.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks. All merged to the master branch now. 


Thanks to IBM that you don't play on your own playground only and you
consolidate things in more generic way!

    Karel



-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux