Re: [PATCH 1/1] fallocate: add insert range support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/11/16 06:51, Fabian Frederick wrote:
> 
> 
>> On 06 November 2016 at 22:43 Pádraig Brady <P@xxxxxxxxxxxxxx> wrote:
>>
>>
>> On 06/11/16 19:38, Fabian Frederick wrote:
>>> @@ -83,6 +88,7 @@ static void __attribute__((__noreturn__)) usage(FILE *out)
>>>      fputs(USAGE_OPTIONS, out);
>>>      fputs(_(" -c, --collapse-range remove a range from the file\n"), out);
>>>      fputs(_(" -d, --dig-holes      detect zeroes and replace with holes\n"),
>>> out);
>>> +   fputs(_(" -i, --insert-range   insert a range in the file\n"), out);
>>
>> The description just repeats the option name.
>> What does insert a range mean exactly?
>> For example how does it compare to the clearly explained:
>>
>>   -z, --zero-range     zero and ensure allocation of a range
> 
> Maybe we could add a reference to "man 2 fallocate" for more details ?

We already do. We should provide some details though. How about:

  +   fputs(_(" -i, --insert-range   insert a hole at range, shifting existing data\n"), out);

thanks,
Pádraig
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux