Re: [PATCH 3/3] tests: always quote $LODEV

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 07, 2016 at 09:58:25AM +0100, Ruediger Meier wrote:
> On Sunday 06 November 2016, Bernhard Voelker wrote:
> > So what happens now when losetup is fed with ""?
> > Wouldn't it be better to handle the error instead?
> 
> Actually the failure is generally handled in terms that the test will 
> fail and exit 1. 

This is the basic idea of the tests; it would be nice to keep it
simple and stupid :-)

> the whole --help output on usage errors. I really hate that auto-help 
> feature. Don't understand why we are doing that instead of just 
> printing "unkown option" or "missing argument".

I'd like to change it for v2.30.

Optionally, it would be also nice to have a way how to suggest the
correct option on typos. I like the way how git react on typos:

        $ git cxmmit
        git: 'cxmmit' is not a git command. See 'git --help'.

        Did you mean this?
            commit



    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux