Re: libfdisk show stopper on i586?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 26, 2016 at 03:26:20AM +0300, Yuriy M. Kaminskiy wrote:
> I doubt it is related, but while looking at this diff I noticed some
> pretty broken (even if accedintally working) code:
> 
> === cut libfdisk/src/gpt.c ===
> 	const char *p = str;
> ...
>                 } else if (isdigit((unsigned int) *p)
> === cut ===

Fixed, I found it on another places too (probably my mistakes, sorry).

> There either should be no explict cast here, or it should've been
> `(unsigned char)*p` instead.

We usually use (unsigned char), so to be consistent I have replaced
the "unsigned int" with "unsigned char".

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux