On 14 July 2016 at 11:01, Karel Zak <kzak@xxxxxxxxxx> wrote: > On Tue, Jul 12, 2016 at 10:42:33PM +0100, Sami Kerola wrote: >> lib/portability.c | 28 ++++++++++++++++++++++++++++ > > We already care about portability and we have many fallbacks, so why > we need lib/portability.c now? It would better to use timeutils.c (or > inline function in c.h). Hi Karel. I didn't do my homework carefully enough. After assuming the timeutils.c should be kept close to simiar with systemd version I thought some other file should be used. But now when I look systemd version of the time-utils.c and compare it with the util-linux copy it's pretty clear these are two very different pieces of code. Change below moved the replacement function to the timeutils.c with necessary commit message update. https://github.com/kerolasa/lelux-utiliteetit/commit/0f916063a4f887f198e005a7a0f7878aa0bfbe05 -- Sami Kerola http://www.iki.fi/kerolasa/ -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
