Hello All Please find the attached patch . Best regards Veeraiyan Chidambaram RBEI/ECF Tel. +91(422)676-4495 -----Original Message----- From: Veeraiyan Chidambaram (RBEI/ECF32) Sent: Monday, July 11, 2016 1:11 PM To: 'util-linux@xxxxxxxxxxxxxxx' <util-linux@xxxxxxxxxxxxxxx>; Veeraiyan Chidambaram (RBEI/ECF32) <Veeraiyan.Chidambaram@xxxxxxxxxxxx> Subject: [PATCH] liblkid: fix probe_nilfs2 I/O error backup Hello All, In our system recently updated libblkid-2.24 to libblkid-2.26. After updating of libblkid, blkid -p -u noraid /dev/sr0 stopped working for my Mixed mode CD (audio + data) and doesnt give any output. libblkid run's probe function to find When I investigated further found probe of nilfs file system is failing with I/O error (before nilfs file system probe iso9660 probe was successful) . The nilfs probe function does the following 1. reads for primary partition 2. read backup partition 3. checks the nilfs related validity checks if validate fails returns 1 meaning CD file system is not an nilfs file system. 4. if validation is successful then copy the necessary information and return 0 meaning CD is nilfs file system. In my case 1. Read of primary portion is successful. 2. Read Backup partition is falls with I/O error. 3. retuns errno -5 here i see a following difference b/w libblkid-2.24 and libblkid-2.26 1. In version 2.24 if backup partition fails they doesn't treat as error but in newer version treated as error. 2. On the whole error handling was changed in libblkid-2.26 , if any file probe return errno, then successful found file system all so discarded , in my case even through iso9660 probe found CD was a iso9660 file system due nilfs probe blkid return errno the successful is9660 results also ignored by liblkid. I would like to propose the following fix In nilfs file system probe 1. read primary partition 2. validate the primary partition if fails return 1 i.e no file system found for nilfs file system in the CD. 3. if backup partition if validate. 4. then validate backup partition and then copy the necessary information and return 0 meaning CD is nilfs file system. -- Thanks &Regards veeraiyan chidambaram
Attachment:
0001-liblkid-fix-probe_nilfs2-I-O-error-backup.patch
Description: 0001-liblkid-fix-probe_nilfs2-I-O-error-backup.patch
