On Thu, Apr 21, 2016 at 12:24:58AM -0700, Victor Dodon wrote:
> Use the return value of fdisk_reread_partition_table in write_changes so that
> sfdisk exits with error if re-reading the partition table fails.
>
> Signed-off-by: Victor Dodon <dodonvictor@xxxxxxxxx>
> ---
> disk-utils/sfdisk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disk-utils/sfdisk.c b/disk-utils/sfdisk.c
> index 15fa99c..b520c9b 100644
> --- a/disk-utils/sfdisk.c
> +++ b/disk-utils/sfdisk.c
> @@ -534,7 +534,7 @@ static int write_changes(struct sfdisk *sf)
> rc = move_partition_data(sf, sf->partno, sf->orig_pa);
> if (!rc) {
> fdisk_info(sf->cxt, _("\nThe partition table has been altered."));
> - fdisk_reread_partition_table(sf->cxt);
> + rc = fdisk_reread_partition_table(sf->cxt);
Yes, the old sfdisk implementation exit with error in this case, but
I'm not sure about it. The problem is that partition table is properly
written to the device (but kernel don't use it). If would be nice to
distinguish between this non-fatal error and another errors. Maybe we
need more return codes.
0 -- success
1 -- fatal error
2 -- minor error (e.g. reread problem)
.. or so. We can also add error codes for initial re-read check, etc.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
