Re: [PATCH] Fix possible NULL dereference in get_btrfs_fs_root()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 30, 2016 at 10:49:43PM +0200, Stanislav Brabec wrote:
> set_fs_root() got it as upd->mountinfo being NULL from utab_new_entry(). That
> got it from mnt_update_set_fs(), that from mnt_context_prepare_update() (where
> it is cxt->update->mountinfo).
> 
> At least the constructor mnt_new_update() can create context with cxt->update
> being not NULL and cxt->update->mountinfo being NULL.
> 
> It is also possible to pass to mnt_context_prepare_update() with cxt->update not
> being NULL but cxt->update->mountinfo being NULL created by mnt_new_context(),
> e. g. from mnt_context_mount().

It's seems better to read mountinfo when really necessary than always.
I have applied something else:

https://github.com/karelzak/util-linux/commit/e9cd2e2bd9ec91a0b1050c4aa79555d142985924

Thanks!
    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux