On Thursday 17 March 2016, Karel Zak wrote: > On Thu, Mar 17, 2016 at 05:52:27PM +0100, Ruediger Meier wrote: > > On Thursday 17 March 2016, Karel Zak wrote: > > > On Thu, Mar 17, 2016 at 11:04:06AM +0100, Ruediger Meier wrote: > > > > We haven't installed these files since three years. Hopefully > > > > they will work. > > > > > > I have added tools/checkcompletion.sh (sorry about my shell > > > programming skills, it requires bash:-), so now: > > > > > > $ make checkcompletion > > > Missing completion scripts: > > > agetty > > > findfs > > > kill > > > line > > > login > > > runuser > > > sulogin > > > switch_root > > > vipw > > > > > > > +if BUILD_MOUNT > > > > +dist_bashcompletion_DATA += bash-completion/mount > > > > +dist_bashcompletion_DATA += bash-completion/umount > > > > +endif > > > > > > ... and checkcompletion does not check for incomplete Makefiles > > > of course, but better than nothing. > > > > Maybe checkcompletion.sh would be more simple and safe if we do > > "make install DESTDIR=/tmp/dest" and compare installed *bin/ > > binaries. > > Good point. > > > with installed completions (and BTW manpages!). It would also > > discover Makefile bugs. I'm sure that such distcheck-hook scripts > > should already exist. Like rpmlint does such checks for the distro > > packages and prints warnings plus counts negative scores: > > > > RPMLINT report: > > =============== > > [...] > > util-linux.x86_64: W: no-manual-page-for-binary flushb > > util-linux.x86_64: W: no-manual-page-for-binary chrp-addnote > > Each executable in standard binary directories should have a man > > page. [...] > > > > > > > > But actually the most simple way to find non-distributed > > files in _general_ is IMO this: > > > > $ make distdir > > $ find util-linux-2.28.rc1-65-5ae7a/ -type f -printf "%P\n" | sort > > > files-dist $ git ls-files | sort > files-git > > $ diff files-git files-dist | grep "^<" > > Well, "make distcheck" already checks if the final tarball is usable > without git tree. Yes, but these commands above showed me clearly that somebody committed bash completions but we neither distribute nor install them! distcheck can't find such issues. BTW I had spent almost one hour with creating very exotic grep/git/find/whatever command line pipes because I _wanted_ to find dead/unused files. Finally above stupid thing worked. Funny that these 3 files were not installed since 3 years but nethertheless maintained and bug fixed a few times. This shows that I'm not the only one who _greps_ for bugs if you don't see any in real life. :) cu, Rudi -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
