Re: [PATCH] include sysmacros.h where used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08 Mar 2016 14:34, Karel Zak wrote:
> On Mon, Mar 07, 2016 at 05:26:33PM -0500, Mike Frysinger wrote:
> > BSD/Linux systems stick major/minor/makedev in sysmacros.h.  Newer Linux
> > libraries have been moving away from including sysmacros.h implicitly via
> > sys/types.h, so include it directly.
> 
> Applied and then reverted ;-) It seems in conflict with Rudi's
> changes. We need #ifdef HAVE_SYS_SYSMACROS_H for the file.
> 
> I have moved it to c.h, it seems better to keep it on one place. (I
> hope it does not have any side effects to have it everywhere.)

hopefully not, but i'd watch out for shadowing.  like lib/linux_version.c
which has variables named "major" and "minor".
-mike

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux