On Fri, Feb 19, 2016 at 12:06:36PM +0100, Ruediger Meier wrote: > But I want to ask whether it would be a good idea to make the message > generally less verbose: > > - if (errno) > + if (errno == ERANGE) > > On other systems strtoul(3p) would return EINVAL too for case --id="XX" > but EINVAL has no useful information here: > > test_logger: failed to parse id: 'XX': Invalid argument > > This would not change anything on Linux/c99 as strtoul(3) only set > ERANGE there. Sound good. Go ahead, thanks! Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html