Re: [PATCH] libmount: run btrfs subvol checks for "auto" fs type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 01, 2016 at 04:20:30PM +0100, Stanislav Brabec wrote:
> Karel Zak wrote:
> >  It's safe, but "mount -a" is going to call the btrfs ioctl or each
> >  "auto" fstab entry :-)
> >
> I am aware of it. Guessing what is more effective: search for all
> candidates in mountinfo and checking whether it is btrfs, or blindly
> issuing ioctl() that will:
> - quickly fail with EINVAL for non-btrfs
> - wil be needed for btrfs anyway

I think the EINVAL based solution is good enough. It's one syscall, be
smart in mountinfo (and canonicalize paths, etc.) is more expensive in
some use-cases.

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux