On Thu, Jan 21, 2016 at 04:45:29PM +0100, Karel Zak wrote: > On Thu, Jan 21, 2016 at 04:37:13PM +0100, Karel Zak wrote: > > > David also wrote btrfs_get_default_subvolume_path(), but then we found, > > > that there is probably better to use subvolid and path saved in > > > procinfo: > > > > Do you mean /proc/self/mountinfo ? > > > > > > > > + The tab.c patch would be much smaller and straightforward. > > > - Kernel evaluates it when creating procinfo entries, this would > > > duplicate it. > > > x Both subvol and subvolid in procinfo were introduced together in the > > > mainline kernel, and btrfs_get_default_subvolume_path() needs more > > > ioctl() calls. > > > > No sure if I follow. > > Read it and the patch again, and now it makes sense. Yes, the ioctl and > subvolid= from mountinfo seems better than dependence on libbtrfs. Also because util-linux is a build dependency for btrfs-progs. -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
