Re: libblkid: blkid_bufinfo() fails on 32bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 03, 2015 at 02:57:06AM +0100, Ruediger Meier wrote:
> but it still looks broken, see this debug output
> 
> 
> libblkid: LOWPROBE: --> starting probing loop [SUBLKS idx=-1]
> libblkid: LOWPROBE: [0] linux_raid_member:
> libblkid: LOWPROBE:     call probefunc()
> libblkid:   BUFFER:     mapping end of the device
> libblkid:   BUFFER:     mmap  0xf7321000: off=4112515072, len=25771900928 (6291968 pages)
>                                                       ^^^^^^^

Yep, fixed.

-#define PROBE_ALIGN_OFF(p, o)  ((o) & ~((p)->mmap_granularity - 1))
+#define PROBE_ALIGN_OFF(p, o)  ((o) & ~((p)->mmap_granularity - 1ULL))

.. it's necessary to be more explicit with constants ;-)

Thanks!

    Karel


>    shouldn't we only mmap about 2M?
> 
> libblkid:   BUFFER:     reuse 0xf7321000: off=4112515072 len=25771900928 (for off=29884407808 len=256)
> libblkid:   BUFFER:     mapping begin of the device
> libblkid:   BUFFER:     mmap  0xf7121000: off=0, len=2097152 (512 pages)
> libblkid:   BUFFER:     reuse 0xf7121000: off=0 len=2097152 (for off=4096 len=256)
> 
> cu,
> Rudi
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux