Re: [PATCH 00/12] pull: race fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 31, 2015 at 07:21:12PM +0000, Sami Kerola wrote:
>   login: fix stat(2) race
>   swapon: fix stat(3) and open(3) race
>   fsck: retire stat(3) when access(3) does better job
>   agetty: fix chown(3), chmod(3) and open(3) race
>   script, hwclock: check file exist with access(3) rather than stat(3)

 Applied, thanks.

>   lib/fileutils: add is_same_inode() check
>   include/blkdev: add open_blkdev_or_file() function
>   mkfs.bfs: fix block device open race
>   mkfs.minix: fix block device open race
>   mkswap: fix block device open race
>   mesg: fix multiple races
>   fdformat: fix block device open race

 Here I don't like the pattern

  open_blkdev_or_file()
  fstat()

 IMHO it would be enough to use is_same_inode() to avoid race.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux