Re: [PATCH 05/12] script, hwclock: check file exist with access(3) rather than stat(3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 31, 2015 at 07:21:17PM +0000, Sami Kerola wrote:
> Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> ---
>  sys-utils/hwclock.c | 5 +----
>  term-utils/script.c | 3 +--
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
> index 4b201d7..0d11061 100644
> --- a/sys-utils/hwclock.c
> +++ b/sys-utils/hwclock.c
> @@ -258,15 +258,12 @@ hw_clock_is_utc(const bool utc, const bool local_opt,
>  static int read_adjtime(struct adjtime *adjtime_p)
>  {
>  	FILE *adjfile;
> -	int rc;			/* local return code */
> -	struct stat statbuf;	/* We don't even use the contents of this. */
>  	char line1[81];		/* String: first line of adjtime file */
>  	char line2[81];		/* String: second line of adjtime file */
>  	char line3[81];		/* String: third line of adjtime file */
>  	long timeval;
>  
> -	rc = stat(adj_file_name, &statbuf);
> -	if (rc < 0 && errno == ENOENT) {
> +	if (access(adj_file_name, R_OK) != 0) {

Not sure, but I remember reports from people who use suid hwclock.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux