Re: [PATCH 2/2] tests: add fsck.minix checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 02, 2015 at 07:29:00PM +0100, Sami Kerola wrote:
>  tests/expected/minix/fsck-images-auto-fix     |  31 ++++++++++++
>  tests/expected/minix/fsck-images-broken-root  |   7 +++
>  tests/expected/minix/fsck-images-bug.773892   |   1 +
>  tests/expected/minix/fsck-images-check-blocks |   9 ++++
>  tests/expected/minix/fsck-images-v1c14        |   9 ++++
>  tests/expected/minix/fsck-images-v1c30        |   9 ++++
>  tests/expected/minix/fsck-images-v2c14        |   9 ++++
>  tests/expected/minix/fsck-images-v2c30        |   9 ++++
>  tests/expected/minix/fsck-images-v3c60        |   9 ++++
>  tests/ts/minix/broken-root                    | Bin 0 -> 5120 bytes
>  tests/ts/minix/debian.bug.773892              | Bin 0 -> 16384 bytes
>  tests/ts/minix/fsck-images                    |  67 ++++++++++++++++++++++++++

Applied, thanks.

> +ts_check_test_command "$TS_CMD_FSCKMINIX"
> +ts_check_test_command "$TS_HELPER_MKFS_MINIX"
> +
> +export MKFS_MINIX_TEST_SECOND_SINCE_EPOCH='1438460212'

You forgot that the filesystem inodes also contains UID and GIT and
mkfs.minix uses getuid()... so the final checksum depends on used
account :-)

Fixed, I have updated the checksums and enabled the tests for root
(UID=0) only.

> +check_minix_fs_type() {
> +	ts_init_subtest $1
> +	dd if=/dev/zero bs=1024 count=16 of=$TS_OUTDIR/$1 >/dev/null 2>&1

$TS_OUTDIR/$1 is outside subtest namespace, fixed to use ${TS_OUTPUT}.img

> +echo "42" > $TS_OUTDIR/badlist
> +check_minix_fs_type 'check-blocks' "-l $TS_OUTDIR/badlist -c"
> +rm -f $TS_OUTDIR/badlist

same here. Fixed.

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux