On Fri, Jul 24, 2015 at 08:23:51AM +0200, Bernhard Voelker wrote: > On 07/24/2015 12:56 AM, Joel Holdsworth wrote: > > This fixes a bug in the build system when building without ncurses > > and tinfo. When cal is linked, it depends on both these libraries > > and will fail to link if either of them is not available. > > > > This patch resolves the issue by explicitly declaring these > > dependencies in the confgure.ac. > > wouldn't this invalidate configure's --without-ncurses option? No, from this point of view the patch is correct UL_BUILD_INIT([cal], [check]) specifies the util as optional, so UL_REQUIRES_HAVE([cal], [ncurses], [ncurses library]) checks for the library and if not found then print WARNING and disable the util. UL_BUILD_INIT([cal], [yes]) specifies that the util is strictly required. Anyway from my point of view the patch is unnecessary as cal.c should be possible to compile without curses and tinfo at all. Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html