On 06.07.2015 16:07, Mike Frysinger wrote: > On 03 Jul 2015 14:58, Stef Walter wrote: > #ifdef AGETTY_RELOAD >> # include <sys/inotify.h> >> +# include <linux/netlink.h> >> +# include <linux/rtnetlink.h> > > why not use libmnl instead ? > http://netfilter.org/projects/libmnl I'm only a sporadic contributor to util-linux. I felt that adding a dependency to util-linux wasn't my place to suggest. In addition this patch performs very very simple usage of the netlink socket. We don't even look at message data. However the mantainers feel this is a better approach, I'd be happy to implement it this way. Are you a maintainer of util-linux (sorry for the dumb question)? >> +static void open_netlink(void) >> +{ >> ... >> + if (bind(sock,(struct sockaddr *)&addr, sizeof(addr)) < 0) > > need space after the first , <snip> Fixed all of these other review items and pushed the patch here: https://github.com/stefwalter/util-linux/commits/agetty-addrchange I'd be happy to repost the patch to the mailing list once a maintainer decides on whether libmnl is necessary or not. Stef -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
