[PATCH 5/7] build-sys: add minimal whitespace build directory support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The commit fixes following issue.

$ ./autogen.sh
[...]
./autogen.sh: line 119: cd: /home/src/util: No such file or directory

And makes build to fail early with an error easier to understand than the
one below.

$ make
[...]
./libtool: line 8988: cd: linux: No such file or directory
libtool: warning: cannot determine absolute directory name of 'linux'
/usr/bin/grep: linux/libuuid.la: No such file or directory
/usr/bin/sed: can't read linux/libuuid.la: No such file or directory
libtool:   error: 'linux/libuuid.la' is not a valid libtool archive

Reference: https://lists.gnu.org/archive/html/bug-libtool/2005-03/msg00132.html
Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
---
 autogen.sh   | 7 ++++++-
 configure.ac | 5 +++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index 546d468..d64ff08 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -86,6 +86,11 @@ test ${ltver##2.} = "$ltver" && {
 	DIE=1
 }
 
+if test `echo $PWD | grep -c '\s'` != "0"; then
+	echo 'built directory cannot have whitespace in its name.'
+	DIE=1
+fi
+
 if test "$DIE" -eq 1; then
 	exit 1
 fi
@@ -116,7 +121,7 @@ autoheader $AH_OPTS
 
 automake --add-missing $AM_OPTS
 
-cd $THEDIR
+cd "$THEDIR"
 
 echo
 echo "Now type '$srcdir/configure' and 'make' to compile."
diff --git a/configure.ac b/configure.ac
index 58feb22..18bee8c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -142,6 +142,11 @@ m4_ifndef([PKG_PROG_PKG_CONFIG],
     ./autogen.sh or autoreconf again.])])
 PKG_PROG_PKG_CONFIG
 
+dnl libtool does not work if the path has a space in it.
+AS_IF([ test `echo $PWD | grep -c '\s'` != "0"  ], [
+  AC_MSG_ERROR([built directory cannot have whitespace in its name.])
+])
+
 GTK_DOC_CHECK([1.10])
 AC_PATH_PROG([XSLTPROC], [xsltproc])
 
-- 
2.4.4

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux