----- Original Message -----
> From: "Ruediger Meier" <sweet_f_a@xxxxxx>
> To: util-linux@xxxxxxxxxxxxxxx
> Cc: "Federico Simoncelli" <fsimonce@xxxxxxxxxx>
> Sent: Wednesday, April 22, 2015 7:43:06 PM
> Subject: blkdiscard progress breakes test
>
> Hi,
>
> Commit c472a7e3 introduced progress messages. This randomly
> breaks the test-suite like this:
>
>
> blkdiscard: offsets ... FAILED (blkdiscard/offsets)
> ....
> ---
> /home/abuild/rpmbuild/BUILD/util-linux-2.26.git233.01aa/tests/expected/blkdiscard/offsets
> 2014-10-28 06:53:35.483698330 +0000
> +++
> /home/abuild/rpmbuild/BUILD/util-linux-2.26.git233.01aa/tests/output/blkdiscard/offsets
> 2015-04-22 15:41:45.748155291 +0000
> @@ -21,7 +21,8 @@
> blkdiscard: offset 1 is not aligned to sector size 512
> blkdiscard: offset 1 is not aligned to sector size 512
> blkdiscard: offset 511 is not aligned to sector size 512
> -Discarded 1536 bytes from the offset 512
> +Discarded 1024 bytes from the offset 512
> +Discarded 512 bytes from the offset 1536
> Discarded 1024 bytes from the offset 1024
> testing misaligned steps full device
> blkdiscard: length 1 is not aligned to sector size 512
>
>
> It's because we ignore timeval's tv_usec here:
> if (last.tv_sec < now.tv_sec) {
> print_stats(path, stats);
>
> We could make it better if we also compare tv_usec but IMO it would be fine
+1 to fix it (rather easy).
> to print the stats only one time at the end. Maybe
> -v prints stats one time only
> -vv report progress
But then -vv needs to be tested anyway.
--
Federico
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
