On Tue, Mar 24, 2015 at 06:16:15PM -0400, Dave Reisner wrote:
> On Tue, Mar 24, 2015 at 09:01:10PM +0100, Stanislav Brabec wrote:
> > Both fsck(8) and fsck --help documents progress bar redirection as
> > -C {fd}
> >
> > This did not work, and only -C{fd} and "-C {fd}" worked.
Applied, thanks (please, Signed-off-by: next time).
> Perhaps rather than break the existing behavior it might be better to
> make the documentation match reality.
Stanislav is right, it's pretty obvious from code:
> > } else if (i+1 < argc && *argv[i+1] != '-') { /* -C <fd> */
> > - progress_fd = string_to_int(argv[i]);
> > + progress_fd = string_to_int(argv[i+1]);
the "if()" checks for the next item in argv[], but string_to_int()
has been used with argv[i].
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
