Re: [PATCH 3/8] tests: add test_logger helper command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 15, 2015 at 12:54:49PM +0000, Sami Kerola wrote:
> +#ifndef TEST_LOGGER
>  	gettimeofday(&tv, NULL);
> +#else
> +	tv.tv_sec = 1234567890;
> +	tv.tv_usec = 123456;
> +#endif

I have replaced this with logger_gettimeofday() macro and read the
value for the tests from LOGGER_TEST_TIMEOFDAY env.variable (and so on
for hostname and pid), for example to be compatible with your tests:

export TZ="GMT"
export LOGGER_TEST_TIMEOFDAY="1234567890.123456"
export LOGGER_TEST_HOSTNAME="test-hostname"
export LOGGER_TEST_GETPID="98765"

I have applied your test without a change (except the environment):

./run.sh logger

-------------------- util-linux regression tests --------------------

                    For development purpose only.                    
                 Don't execute on production system!                 

       logger: options                        ...
                : simple                      ... OK
                : log_pid                     ... OK
                : log_pid_long                ... OK
                : log_pid_define              ... OK
                : log_pid_no_arg              ... OK
                : input_file_simple           ... OK
                : input_file_empty_line       ... OK
                : input_file_skip_empty       ... OK
                : input_file_prio_prefix      ... OK
           ... OK (all 9 sub-tests PASSED)


It would be also nice to have tests for --rfc5424[=...] messages formatting.

   Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux