On Sun, Mar 15, 2015 at 1:54 PM, Sami Kerola <kerolasa@xxxxxx> wrote:
Quick question on this (especially for future work):
> @@ -387,29 +386,35 @@ static void syslog_rfc3164_header(struct logger_ctl *const ctl)
> #define NILVALUE "-"
> static void syslog_rfc5424_header(struct logger_ctl *const ctl)
> {
> + char *time;
> + char *hostname;
> + char *const app_name = ctl->tag;
> + char *procid;
> + char *const msgid = xstrdup(ctl->msgid ? ctl->msgid : NILVALUE);
> + char *structured_data;
Is it project policy to always define variables at the beginning of
the function? I ask because I used to do that as well, before I got
educated last year that it helps the compiler to produce better code
if variables are declared where needed.
Also on the idention: I assume indention via tabs with tabwidth 4. Is
there a style document I an look at?
Thanks and sorry for the extra effort.
Rainer
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
