On Sun, Mar 01, 2015 at 11:46:11AM +0000, Sami Kerola wrote: > Moving to monotonic sounds good to me. Notice that there is linking change > in configure.ac making monotonic.c to be linked with -lrt even when > clock_gettime() would not require it. The timer_create() requires -lrt at > last for now. > > https://github.com/kerolasa/lelux-utiliteetit/commit/50425160a825986abb4e9c22ef8acee8e7b34834 OK. > s/CLOCKGETTIME_LIBS/UL_REALTIME_LIBS/ > > Better? Yeah. > Correct. After the change flock(1) cannot be forced to timeout by sending > an ALRM signal. Is that good, bad, or possible regression is debatable. I > think allowing external signals to cause timeout is unintented behavior. I think it's better to split signals and timers. > Function pointer is added. > > https://github.com/kerolasa/lelux-utiliteetit/commit/50425160a825986abb4e9c22ef8acee8e7b34834 You forgot to update commit message ("This code is moved ..."). Anyway, looks good. Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
