Re: [PATCH 10/13] bash-completion: add freeze mode to rtcwake

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 24 Feb 2015, Karel Zak wrote:

> On Sun, Feb 22, 2015 at 02:42:16PM +0000, Sami Kerola wrote:
> > Missed when commit ece44f19f423408f576f348fed2845c876d72c6e added support
> > to freeze.
> > 
> > Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> > ---
> >  bash-completion/rtcwake | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/bash-completion/rtcwake b/bash-completion/rtcwake
> > index 51566a2..70ae743 100644
> > --- a/bash-completion/rtcwake
> > +++ b/bash-completion/rtcwake
> > @@ -12,7 +12,7 @@ _rtcwake_module()
> >  			return 0
> >  			;;
> >  		'-m'|'--mode')
> > -			COMPREPLY=( $(compgen -W "standby mem disk off no on disable show" -- $cur) )
> > +			COMPREPLY=( $(compgen -W "standby freeze mem disk off no on disable show" -- $cur) )
> 
>  would be possible to ask rtcwake(8) for all supported modes rather
>  than hard code it to the bash-completion script?

Thanks Karel,

Great idea. Change is updated to provide dynamic mode listing.

https://github.com/kerolasa/lelux-utiliteetit/commit/d827893773d9b565c42dd3300cdf4495891a08b2

Notice that the later change will update the listing to include only the 
modes from /sys/power/state.

https://github.com/kerolasa/lelux-utiliteetit/commit/9c147fa6ae5d4a8dcbb40e4bb8d6b82c408c52ed

-- 
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux