Re: [PATCH 11/13] rtcwake: improve coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 23 Feb 2015, Benno Schulenberg wrote:

> On Sun, Feb 22, 2015, at 15:42, Sami Kerola wrote:
> > -	/* this process works in RTC time, except when working
> > -	 * with the system clock (which always uses UTC).
> > -	 */
> > +	/* this process works in RTC time, except when working with the
> > +	 * system clock (which always uses UTC). */
> 
> Since this and the other comments ends with a period, it really
> should start with a capital.  When changing the line anyway...

Oopps. I fixed the commits as part of other commit.

https://github.com/kerolasa/lelux-utiliteetit/commit/021378dd2baae75e42014b5e1cc595e8c1ab96bc

And missed the few time/date improvements you mentioned in mail:

Date: Mon, 23 Feb 2015 21:32:34 +0100
From: Benno Schulenberg <bensberg@xxxxxxxxxxxxx>
To: Sami Kerola <kerolasa@xxxxxx>
Cc: Util-Linux <util-linux@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 06/13] rtcwake: add human readable --date timestamp format

Perhaps string improvements can be done later with corrections to last(1) 
as well. If I remember right I copied the messages from last(1) pretty 
much as-is.

-- 
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux