Re: [PATCH 18/31] more: split run time help screen to multiple translatable lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 22, 2015, at 15:43, Sami Kerola wrote:
> -	fputs(_("\n"
> -		"Most commands optionally preceded by integer argument k.  "
> -		"Defaults in brackets.\n"
> -		"Star (*) indicates argument becomes new default.\n"), stdout);
> [...]
> +	fputs(  "\n", stdout);
> +	fputs(_("Most commands optionally preceded by integer argument k.\n"), stdout);
> +	fputs(_("Defaults in brackets.\n"), stdout);
> +	fputs(_("Star (*) indicates argument becomes new default.\n"), stdout);

These three sentences are somewhat interrelated, so it is better to keep
them in a single translatable string, as it was.  It would have been nice
to take out the leading newline, but it's not worth invalidating all the
existing translations.  So I suggest keeping the first fputs() unchanged.
Splitting up all the other lines is fine.

> +	fputs(_("q or Q or <interrupt>   Exit from more\n"), stdout);

Interrupt is always ctrl-C, no?  If so, then better use that, as
it matches the representation of the other ctrl combos.

> +	fputs(_("/<regular expression>   Search for kth occurrence of regular expression [1]\n"), stdout);

In order to be able to reduce the amount of whitespace between
key name and explanation in the whole help screen, I would
suggest replacing <regular expression> with <regexp>, which
is a very common abbreviation.

> +	fputs(_("n                       Search for kth occurrence of last r.e [1]\n"), stdout);

s/r.e/regexp/

> +	fputs(_("!<cmd> or :!<cmd>       Execute <cmd> in a subshell\n"), stdout);

Hmm...  Are there certain circumstances where ! doesn't work and
:! is needed?  If not, I would suggest dropping the second form,
to reduce the space between keys and explanations.  A help screen
doesn't have to tell everything, that's what the man page is for.

> +	fputs(_("ctrl-L                  Redraw screen\n"), stdout);

For all key explanations: start them with a lowercase letter, as they
don't end in a period either.

Benno

-- 
http://www.fastmail.com - Choose from over 50 domains or use your own

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux