On Fri, Jan 30, 2015, at 09:54, Sami Kerola wrote: > This removes isprint(c) column++ from get_line() that made underlining, > bold, and other control characters to cause more display to wrap lines Suggestion: s/more display/'more'/ > incorrectly. Easiest way to see the difference is to run following > before and after compiling this change. > > PAGER=./more man man Could you include in this description a snippet of the observed changes? Also, it would be nice to see the patch split into two: one that changes the logic, and one that adjusts the whitespace for the changed logic. (Once the patch is in git, one can of course use 'git log -p -w' to see just the changed logic among all the changed whitespace, but from just a plain email this is a bit hard to do. Or maybe you yourself could post a -p -w diff as a follow-up to the full patch to show the essential changes. Because it seems that also github is not able to strip whitespace changes from diffs.) Benno -- http://www.fastmail.com - Same, same, but different... -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
