Re: [PATCH V3] docs: fix grammar and punctuation and typos in 2.26 release notes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 19, 2015 at 10:08:23PM +0100, Benno Schulenberg wrote:
> Also trim some trailing whitespace.
> 
> Reviewed-by: Peter Cordes <peter@xxxxxxxxx>
> Signed-off-by: Benno Schulenberg <bensberg@xxxxxxxxxxxxx>
> ---
>  Documentation/releases/v2.26-ReleaseNotes |   74 ++++++++++++++--------------
>  1 files changed, 37 insertions(+), 37 deletions(-)
> 
> diff --git a/Documentation/releases/v2.26-ReleaseNotes b/Documentation/releases/v2.26-ReleaseNotes
> index b7712f7..655aebe 100644
> --- a/Documentation/releases/v2.26-ReleaseNotes
> +++ b/Documentation/releases/v2.26-ReleaseNotes
> @@ -1,29 +1,29 @@
>  Util-linux 2.26 Release Notes
>  =============================
>  
> - This version provides completely new sfdisk(8) command, the new version is
> - based on libfdisk. If your use-cases depend on sfdisk(8) then it is strongly
> + This version provides a completely new sfdisk(8) command; the new version is
> + based on libfdisk. If your use cases depend on sfdisk(8), then it is strongly
>   recommended to be careful and re-test your scripts. The new version supports
> - MBR and GPT disk labels (SGI and SUN are also supported but no well tested).
> - The new version does no more support some obscure MBR specific command line
> - options and legacy CHS addressing.
> + MBR and GPT disk labels (SGI and SUN are also supported but not well tested).
> + The new version no longer supports some obscure MBR-specific command-line
> + options nor legacy CHS addressing.

 I think it's still not quite proper English, and might be worse.  I
think you might technically need an "either" to introduce the list, to
make "no longer supports" apply to "MBR opts or CHS addressing".  Like
a map operator.  But I'm not sure, and I don't want to take the time to
track it down.

 It doesn't really matter.  Leave it, or go back to "and", and people
will understand the "foreigner speak" if they notice a problem at all. :P

 Or change it to:

+ The new version drops support for some obscure MBR-specific command-line
+ options and legacy CHS addressing.

 I think that's fine without an "either" or a "both", but I can't
explain why.  Oh, the problems of knowing English without having been
formally taught all the grammar rules.  If I'd gone to school decades
earlier than I did, I'm sure I would have been taught all this stuff
formally. :P

-- 
#define X(x,y) x##y
Peter Cordes ;  e-mail: X(peter@cor , des.ca)

"The gods confound the man who first found out how to distinguish the hours!
 Confound him, too, who in this place set up a sundial, to cut and hack
 my day so wretchedly into small pieces!" -- Plautus, 200 BC
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux