On Tue, Jan 6, 2015, at 11:35, Karel Zak wrote:
> I think it would be enough to add a note into man page that
> things are not perfect and supported features depends on kernel.
Okay. Patch coming up.
I think it would also be nice if setarch differentiated between not
recognizing any architecture in the provided string and not being
able to set the architecture to the recognized one. On my machine:
$ ./setarch sometypo uname -m
setarch: sometypo: Unrecognized architecture
$ ./setarch ia64 uname -m
setarch: Kernel cannot set architecture to ia64
This change is included in the upcoming patches, but I have no
idea whether this is correct.
Another thing:
$ ./setarch -BRF --help | tail -1
For more details see setarch(8).
$ ./setarch -BRF --version
setarch from util-linux 2.25.634-8501-dirty
$ ./setarch -BRF --list
./setarch: unrecognized option '--list'
setarch: Try `setarch --help' for more information.
Nowhere does it say that --list cannot be combined with other
options. Instead of adding such a remark, upcoming patch makes
it be accepted in combinations, just like --help and --version.
By the way, in setarch.c there are two occurrences of:
if (argc < 1)
show_usage(_("Not enough arguments"));
Isn't the first one superfluous? I cannot trigger it.
Benno
--
http://www.fastmail.com - mmm... Fastmail...
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
