Re: [PATCH 10/10] ipcs: fix two data type errors [AddressSanitizer]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 8 Dec 2014, Karel Zak wrote:

ipc_shm_get_limits() is also broken

The function shmctl() has to be always called with "struct shmid_ds"
and then cast to linux specific shmid_info struct.

It would be nice to check that all the shm/sem/msgctl functions are
really called with proper arguments.

(Or we can define any union and use it as buffer to make sure that
 the argument is large enough.)

How about doing further corrections later?

BTW, horrible API (or I need more coffee to understand this art).

Mostly because of I share the view above. Getting ipc api usage right is not quite as easy task as one might hope.

--
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux