On Wed, Dec 17, 2014 at 09:20:31PM +0100, Benno Schulenberg wrote: > For mkfs.cramfs, mkfs.minix, blkid and chrt I've had to > improvise -- putting the docstring before the synopis -- in order to > avoid making extensive changes to the usage text; those changes will > come later.) hmm.. it would be better to be consistent and add the docstring to the same position in all utils. (IMHO the best position is between "usage:" and "options:" line.) > can improve its description. Other improvements and comments are > welcome too. you forgot _() NLS macro: > + fputs("Tell the kernel about the existence of a specified partition.\n", out); should be: fputs(_("Tell the kernel about the existence of a specified partition.\n"), out); Anyway, good work! Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html