On Tue, Nov 18, 2014 at 09:28:51AM -0500, Dave Reisner wrote: > On Nov 18, 2014 8:00 AM, "Karel Zak" <kzak@xxxxxxxxxx> wrote: > > > > On Sat, Nov 15, 2014 at 10:36:04PM +0200, Ville Skyttä wrote: > > > bash-completion/chsh | 2 +- > > > bash-completion/eject | 2 +- > > > bash-completion/findmnt | 8 ++++---- > > > bash-completion/losetup | 4 ++-- > > > bash-completion/lsblk | 2 +- > > > bash-completion/setarch | 2 +- > > > bash-completion/setpriv | 2 +- > > > 7 files changed, 11 insertions(+), 11 deletions(-) > > > > Applied, thanks! > > > > Karel > > > > I think this patch breaks completions when used with binaries from a build > root containing whitespace in the path. The use is probably rare, but fix For example? > is simple -- quote the $1. The commands inside $() have their own separate > level of quoting, i.e. "$("$1" -X)" is what we want. Ville, any comment? Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html