Re: [PATCH 0/5] hwclock: clean up messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/24/2014 07:08 AM, Karel Zak wrote:
> On Thu, Oct 23, 2014 at 10:44:31PM -0400, JWP wrote:
>> This patch set cleans up various message output.
>> It contains cosmetic changes only.
>>
>> J William Piggott (5):
>>   hwclock: Remove newline from 'date' debug output
>>   hwclock: clean up message periods/full stops
>>   hwclock: add message line breaks
>>   hwclock: Fix --date debug messages
>>   hwclock: version prints out of order
> 
> I'm going to merge these patches, but as a long term solution it would
> better to use include/debug.h stuff (see for example
> misc-utils/whereis.c or libmount/src/init.c).
> 
> The debug.h provides more elegant way for debug messages. It's
> possible to define mask to specify wanted messages and all is
> controlled by <NAME>_DEBUG= env. variable etc. 
> 
> It's probably too verbose for hwclock --debug, but let's ignore this
> problem for now. I'll make the output more user friendly ASAP.

Cool, I was not aware of debug.h. I will check it out and include it
in my hwclock refactoring todo notes.

> 
>     Karel
> 
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux