Re: [PATCH 20/23] libsmartcols: add explicit column flags default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 28, 2014 at 08:51:53PM +0100, Sami Kerola wrote:
> Useful when initializing without any specific action in mind, or when
> reseting flags later on.
> 
> Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> ---
>  libsmartcols/src/libsmartcols.h.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libsmartcols/src/libsmartcols.h.in b/libsmartcols/src/libsmartcols.h.in
> index e612560..1699a4a 100644
> --- a/libsmartcols/src/libsmartcols.h.in
> +++ b/libsmartcols/src/libsmartcols.h.in
> @@ -78,6 +78,7 @@ enum {
>   * Column flags
>   */
>  enum {
> +	SCOLS_FL_DEFAULT     = 0,	   /* use default functionality */

 it would be better to use

    SCOLS_FL_NONE

>  	SCOLS_FL_TRUNC       = (1 << 0),   /* truncate fields data if necessary */
>  	SCOLS_FL_TREE        = (1 << 1),   /* use tree "ascii art" */
>  	SCOLS_FL_RIGHT	     = (1 << 2),   /* align to the right */


    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux