On Sun, Sep 28, 2014 at 08:51:45PM +0100, Sami Kerola wrote:
> Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> ---
> libblkid/src/superblocks/zfs.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/libblkid/src/superblocks/zfs.c b/libblkid/src/superblocks/zfs.c
> index 6ffa24d..088d110 100644
> --- a/libblkid/src/superblocks/zfs.c
> +++ b/libblkid/src/superblocks/zfs.c
> @@ -156,7 +156,6 @@ static void zfs_extract_guid_name(blkid_probe pr, loff_t offset)
> }
> }
>
> -#define zdebug(fmt, ...) do {} while(0)
> /*#define zdebug(fmt, a...) fprintf(stderr, fmt, ##a)*/
>
> /* ZFS has 128x1kB host-endian root blocks, stored in 2 areas at the start
> @@ -172,7 +171,9 @@ static int probe_zfs(blkid_probe pr,
> int tried;
> int found;
>
> +#ifdef zdebug
> zdebug("probe_zfs\n");
> +#endif
no, this is bad way. It's always better to use empty macros than
#ifdef, ifdef is evil
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
