Re: [PATCH 17/17] setarch: remove unreachable code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 12 Sep 2014, Karel Zak wrote:

On Sun, Sep 07, 2014 at 01:43:05PM +0100, Sami Kerola wrote:
Architectures are protected using '#if defined' clauses, making the code
in this removal to be impossible to reach.

Hmmm.. I guess the code tries to verify that the result architecture
after personality() matches with uname.machine (except to
i{486,586,...}), to be sure that our request has been correctly
interpreted by kernel.

IMHO it's correct.

I removed the change from incoming pull request, and try to improve the 'Unrecognized architecture' message this week. Since the condition looks impossible reach maybe the message should encourage to report to util-linux maillist with which transitions[i].result_arch and un.machine values one was able to see it.

--
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux