On Wed, Jul 23, 2014 at 07:39:02PM +0200, Andreas Henriksson wrote: > The "linux only" check for pivot_root seems to suffer from > a cut-n-paste problem from the earlier switch_root part. > > Signed-off-by: Andreas Henriksson <andreas@xxxxxxxx> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index db53dff..aae2456 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1193,7 +1193,7 @@ AC_ARG_ENABLE([pivot_root], > [], [UL_DEFAULT_ENABLE([pivot_root], [check])] > ) > UL_BUILD_INIT([pivot_root]) > -UL_REQUIRES_LINUX([switch_root]) > +UL_REQUIRES_LINUX([pivot_root]) Is this really correct? Seems to me like the check should simply be removed. In sys-utils/pivot_root.c, we have the following: #define pivot_root(new_root,put_old) syscall(SYS_pivot_root,new_root,put_old) So, the subsequent check for the syscall seems like the only necessary check needed. As is, I think that u-l now fails to build in places where the pivot_root wrapper doesn't exist in the libc, but the syscall exists (does such a platform even exist?). Cheers, dave > UL_REQUIRES_SYSCALL_CHECK([pivot_root], [UL_CHECK_SYSCALL([pivot_root])]) > AM_CONDITIONAL([BUILD_PIVOT_ROOT], [test "x$build_pivot_root" = xyes]) > > -- > 2.0.1 > > -- > To unsubscribe from this list: send the line "unsubscribe util-linux" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
