On Tue, Jul 15, 2014 at 09:35:55AM +0200, Stef Walter wrote: > On 14.07.2014 15:37, Karel Zak wrote: > > On Mon, Jul 07, 2014 at 09:31:24AM +0200, Stef Walter wrote: > >> Several of the /etc/issue escape codes such as \4 and \S depend on > >> variable data which can change after the agetty prompt is displayed. > >> This can cause stale data to be displayed when a user looks at a VT, > >> especially in cases of DHCP racing with system start up. > >> > >> This commit allows agetty to react a SIGUSR1 signal by reprinting > >> its prompt including the reprocessing of /etc/issue. > >> > >> We never want this to occur once the user has started typing a > >> user name. So we detect when the user starts typing, after which > >> no further reprompting occurs even if SIGUSR1 is received. > > > > Good idea, interesting implementation, but it's too late for v2.25. > > I'm going to apply the patch to the git tree after v2.25 release. > > Nice. Thanks. I have never seen the idea with VMIN and TIOCSTI ioctl, that's interesting thing. > Lennart discovered an issue with this ... > > That the exec'ing the login process might race with the SIGUSR1 signal. > The fix here would be to signal(SIGUSR1, SIG_IGN) before exec'ing, does > that sound appropriate? I can post a new patch. > > By the way, more information about this use case here: > https://bugzilla.redhat.com/show_bug.cgi?id=1110763 Yes, I read it yesterday evening. Lennart is right about the race. Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
