Re: fallocate: --punch option parsing error diagnostics irritating

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 26, 2014 at 02:14:01PM +0200, Bernhard Voelker wrote:
> The patch below fixes it.

 Applied, thanks.

> BTW: I think fallocate(1) shouldn't open(...,O_CREAT)
> with -d, -p, and maybe with -z, should it?

Good catch, I think O_CREAT makes sense only for the default
fallocate(2) behavior when no mode is specified and new file is
allocated. All another modes work with existing data/holes. 

Fixed.

    Karel


PS. I love this on-line development and brain storming, git & OSS is
    the best :-)

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux