On Sun, May 18, 2014 at 03:05:30PM +0100, Sami Kerola wrote:
> + ctl->opt_repeat = set_opt_flag(ctl->opt_repeat);
> + ctl->opt_rep_on = parse_switch(optarg, "on", "off");
...
> + ctl->opt_foreground = set_opt_flag(ctl->opt_foreground);
> + ctl->opt_fo_color = parse_febg_color(optarg);
It would be nice (by another patch!) consolidate the names of the
options. For example opt_foreground and opt_fo_color is brain dead.
What about:
ctl->opt_repeat
ctl->opt_repeat_on
and
ctl->opt_foreground
ctl->opt_foreground_color
etc. Maybe the whole "opt_" prefix is unnecessary.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
